Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURA-10951_gh_build_curapackage #3

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Conversation

jellespijker
Copy link
Member

@jellespijker jellespijker commented Aug 29, 2023

Modernized and make use of the new sipbuildtool and pyprojecttoolchain See: Ultimaker/conan-ultimaker-index#8

Merged to main because this is also a problem there, just not visible because of the caching on the runners

In this commit, conandata.yml was deleted as the Python library requirements are now defined in conanfile.py. Incorporated a stricter check for the minimum required C++ standard and for specific compiler versions for better code compatibility. Moreover, modified the function calls in conanfile.py and test_package/conanfiles.py to use more updated and reliable methods. Adjusted build requirements and export sources to improve the building process. Finally, optimized the packaging process to ensure that all necessary files are included in the correct directories.

Contributes to CURA-10951
Contributes to CURA-10951
Contributes to CURA-10951
Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM



required_conan_version = ">=1.50.0"
required_conan_version = ">=1.56.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as pynest (1.58?)

@rburema rburema merged commit 7475fb5 into main Sep 8, 2023
9 checks passed
@rburema rburema deleted the CURA-10951_gh_build_curapackage branch September 8, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants